libenchao commented on code in PR #3436:
URL: https://github.com/apache/calcite/pull/3436#discussion_r1377490273
##########
core/src/main/java/org/apache/calcite/tools/Programs.java:
##########
@@ -250,11 +250,12 @@ public static Program getProgram() {
/** Returns the standard program used by Prepare. */
public static Program standard() {
- return standard(DefaultRelMetadataProvider.INSTANCE);
+ return standard(DefaultRelMetadataProvider.INSTANCE, true);
}
/** Returns the standard program with user metadata provider. */
- public static Program standard(RelMetadataProvider metadataProvider) {
+ public static Program standard(RelMetadataProvider metadataProvider,
Review Comment:
I'm afraid that this is a public API that we need to consider compatibility.
##########
testkit/src/main/java/org/apache/calcite/test/CalciteAssert.java:
##########
@@ -679,6 +679,7 @@ static void assertPrepare(
Connection connection,
String sql,
boolean materializationsEnabled,
+ List<Pair<Hook, Consumer>> hooks,
Review Comment:
This is also a public API (testkit are expected to be used by third party
projects)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
