PaulJackson123 commented on code in PR #3495:
URL: https://github.com/apache/calcite/pull/3495#discussion_r1406906271
##########
core/src/main/java/org/apache/calcite/sql/SqlOverOperator.java:
##########
@@ -115,6 +115,7 @@ public SqlOverOperator() {
// Copied from validateOperands
validator.setValidatedNodeType(call, ret);
+ // TODO: Should the type of the agg change just because it is an OVER
operand?
Review Comment:
I removed the following line to work around [CALCITE-6126], but that broke
other tests in ways I did not understand, so I left this comment. I'm happy to
remove it if this is not best practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
