julianhyde commented on PR #3590: URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867061770
@mihaibudiu The danger with your approach is that, by working on the AST, you automatically fix errors. E.g. you might accidentally change STARTSWITH to STARTS_WITH and not notice that STARTSWITH is a reserved word. Or the unparser might convert things to upper-case. For this, I favor a brute force approach that generates strings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
