caicancai commented on code in PR #3586: URL: https://github.com/apache/calcite/pull/3586#discussion_r1434803576
########## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ########## @@ -11948,6 +11984,25 @@ void testTimestampDiff(boolean coercionEnabled) { f.checkFails("datediff(^\"MONTH\"^, '2019-09-14', '2019-09-15')", "(?s)Column 'MONTH' not found in any table", false); + final SqlOperatorFixture f0 = f.withLibrary(SqlLibrary.BIG_QUERY); + f0.checkScalar("date_diff(DATE '2010-07-07', DATE '2008-12-25', DAY)", + "559", + "INTEGER NOT NULL"); + f0.checkScalar("date_diff(DATE '2010-07-14', DATE '2010-07-07', WEEK)", + "1", + "INTEGER NOT NULL"); + f0.checkScalar("date_diff(DATE '2011-12-14', DATE '2011-07-14', MONTH)", + "5", + "INTEGER NOT NULL"); + f0.checkScalar("date_diff(DATE '2011-10-14', DATE '2011-07-14', QUARTER)", + "1", + "INTEGER NOT NULL"); + f0.checkScalar("date_diff(DATE '2021-07-14', DATE '2011-07-14', YEAR)", + "10", + "INTEGER NOT NULL"); + f0.checkNull("date_diff(CAST(NULL AS DATE), CAST(NULL AS DATE), DAY)"); + f0.checkNull("date_diff(CAST(NULL AS DATE), CAST(NULL AS DATE), DAY)"); Review Comment: outdated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org