HanumathRao commented on PR #3597: URL: https://github.com/apache/calcite/pull/3597#issuecomment-1891083336
> The code looks pretty good, my comments are about readability mostly. I am not familiar with this part of the codebase; perhaps a more experienced reviewer would understand faster. But in general I really prefer the code to be as simple and clear as possible. It helps everyone: reviewers, people who debug it, people who edit it in the future. Some of my suggestions may be not strictly necessary, like reverting the negated variables "cannotTransform", but I think they do really help. Some of the comments you made in the PR should probably be in the code as well; the PR will be lost, but the code stays. Thank you for your review comments. I have addressed the comments and provided inline replies where necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
