tanclary commented on code in PR #3697: URL: https://github.com/apache/calcite/pull/3697#discussion_r1496679874
########## core/src/test/java/org/apache/calcite/sql/type/RelDataTypeSystemTest.java: ########## @@ -118,6 +126,13 @@ private static final class CustomTypeSystem extends RelDataTypeSystemImpl { @Override public int getMaxNumericPrecision() { return 38; } + + @Override public int getMaxPrecision(SqlTypeName typeName) { + if (typeName == SqlTypeName.TIMESTAMP) { Review Comment: To be honest I misread how this was working. What you had before is fine but this should work too. sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org