mihaibudiu commented on code in PR #3640:
URL: https://github.com/apache/calcite/pull/3640#discussion_r1498027961


##########
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##########
@@ -286,6 +286,22 @@ public static Set<CorrelationId> getVariablesUsed(RelNode 
rel) {
     return visitor.vuv.variables;
   }
 
+  /**
+   * Returns a set of variables used by the given list of sub-queries and its 
descendants.
+   *
+   * <p> Internally it uses the {@link 
org.apache.calcite.plan.RelOptUtil#getVariablesUsed}
+   * to get all the variables used in the relational expression of a given 
sub-query.
+   *
+   * <p> The item type is same as {@link 
org.apache.calcite.rex.RexCorrelVariable#id}.

Review Comment:
   Javadoc can document type parameters, use that format: 
https://www.baeldung.com/java-javadoc-generic-type-parameters



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to