Anthrino commented on code in PR #3677:
URL: https://github.com/apache/calcite/pull/3677#discussion_r1498178354
##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -832,6 +858,25 @@ public RexNode makeAbstractCast(RelDataType type, RexNode
exp, boolean safe) {
return new RexCall(type, operator, ImmutableList.of(exp));
}
+ /**
+ * Creates a call to CAST or SAFE_CAST operator with a FORMAT clause.
+ *
+ * @param type Type to cast to
+ * @param exp Expression being cast
+ * @param safe Whether to return NULL if cast fails
+ * @param format Conversion format for target type
+ * @return Call to CAST operator
+ */
+ public RexNode makeAbstractCast(RelDataType type, RexNode exp, boolean safe,
RexLiteral format) {
+ SqlOperator operator =
Review Comment:
Yes that should work, will make the change to the existing
`makeAbstractCast` overload too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
