caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1498540809
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2788,6 +2788,18 @@ public static double log(BigDecimal d0, BigDecimal d1) {
return Math.log(d0.doubleValue()) / Math.log(d1.doubleValue());
}
+ /** SQL {@code LOG2(number)} function applied to double values. */
+ public static double log2(double d0) {
+ return (Double.isInfinite(log(d0, 2)) && d0 == 0.0) ? Double.NaN : log(d0,
2);
+ }
+
+ /** SQL {@code LOG2(number)} function applied to
+ * BigDecimal and double values. */
+ public static double log2(BigDecimal d0) {
+ return (Double.isInfinite(log(d0, 2)) && d0.doubleValue() == 0.0) ?
Double.NaN : log(d0, 2);
Review Comment:
Maybe I'm not sure how to modify it correctly and how to modify it
appropriately. I hope to adapt it with minimal changes. At the moment, I'm not
sure whether it's appropriate to modify comparingResultSet. I will try to find
the best solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
