tanclary commented on code in PR #3706: URL: https://github.com/apache/calcite/pull/3706#discussion_r1503567964
########## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ########## @@ -6268,6 +6268,18 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias functionAlias) { f.checkScalar("rand_integer(2, 11)", 1, "INTEGER NOT NULL"); } + /** Test case for <a href="https://issues.apache.org/jira/browse/CALCITE-6283"> + * [CALCITE-6283] Function array_append with a NULL array argument crashes with + * NullPointerException</a>. */ + @Test void testArrayNullFunc() { + final SqlOperatorFixture f = fixture().withLibrary(SqlLibrary.SPARK); + f.checkNull("array_append(null, 2)"); + f.checkNull("array_prepend(null, 2)"); + f.checkNull("array_remove(null, 2)"); + f.checkNull("array_contains(null, 2)"); Review Comment: I meant a test where the element is null, not the array. But i found that we do so that's good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org