mihaibudiu commented on code in PR #3708: URL: https://github.com/apache/calcite/pull/3708#discussion_r1509921263
########## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ########## @@ -1320,7 +1320,7 @@ void testCastStringToDateTime(CastType castType, SqlOperatorFixture f) { f.checkCastToString("DATE '1945-2-24'", null, "1945-02-24", castType); f.checkScalar("cast('1945-02-24' as DATE)", "1945-02-24", "DATE NOT NULL"); - f.checkScalar("cast(' 1945-02-04 ' as DATE)", "1945-02-04", "DATE NOT NULL"); Review Comment: I am afraid we have to change the tests because they are wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org