Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

[via GitHub]

YiwenWu commented on code in PR #3712:
URL: https://github.com/apache/calcite/pull/3712#discussion_r1516138987


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -691,7 +691,10 @@ private static int makeRegexpFlags(String stringFlags) {
 
     /** SQL {@code RLIKE} function. */
     public boolean rlike(String s, String pattern) {
-      return cache.getUnchecked(new Key(0, pattern)).matcher(s).find();
+      // Since Spark 2.0, string literals (including regex patterns) are 
unescaped in SQL parser

Review Comment:
   Yes, judging by the engine execution behavior, Hive also performs the 
unescape, and the result is consistent with Spark.
   
![image](https://github.com/apache/calcite/assets/7956306/0cf70e02-afd3-4b48-b0b1-5dcd6e86a204)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org