caicancai commented on code in PR #3721: URL: https://github.com/apache/calcite/pull/3721#discussion_r1518526301
########## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ########## @@ -1458,14 +1508,14 @@ private static RelDataType deriveTypeMapConcat(SqlOperatorBinding opBinding) { @LibraryOperator(libraries = {SPARK}) public static final SqlFunction MAP_KEYS = SqlBasicFunction.create(SqlKind.MAP_KEYS, - ReturnTypes.TO_MAP_KEYS_NULLABLE, + SqlLibraryOperators::mapKeyReturnType, OperandTypes.MAP); /** The "MAP_VALUES(map)" function. */ @LibraryOperator(libraries = {SPARK}) public static final SqlFunction MAP_VALUES = SqlBasicFunction.create(SqlKind.MAP_VALUES, - ReturnTypes.TO_MAP_VALUES_NULLABLE, Review Comment: I have deleted ########## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ########## @@ -1458,14 +1508,14 @@ private static RelDataType deriveTypeMapConcat(SqlOperatorBinding opBinding) { @LibraryOperator(libraries = {SPARK}) public static final SqlFunction MAP_KEYS = SqlBasicFunction.create(SqlKind.MAP_KEYS, - ReturnTypes.TO_MAP_KEYS_NULLABLE, + SqlLibraryOperators::mapKeyReturnType, OperandTypes.MAP); /** The "MAP_VALUES(map)" function. */ @LibraryOperator(libraries = {SPARK}) public static final SqlFunction MAP_VALUES = SqlBasicFunction.create(SqlKind.MAP_VALUES, - ReturnTypes.TO_MAP_VALUES_NULLABLE, Review Comment: I have deleted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org