rubenada commented on code in PR #3778:
URL: https://github.com/apache/calcite/pull/3778#discussion_r1582836823
##########
arrow/build.gradle.kts:
##########
@@ -36,6 +37,7 @@ dependencies {
plugins.withType<JavaPlugin> {
tasks {
configureEach<Test> {
+ enabled = !OperatingSystem.current().isWindows
Review Comment:
It seems it is sufficient to exclude just the arrow tests, so I'd vote to go
with this less drastic approach. LGTM 👍
Minor: perhaps we should add some comments, e.g.:
```
// Arrow test is disabled because it is not supported on Windows
// See https://arrow.apache.org/docs/java/install.html#system-compatibility
```
And since we are touching this file, maybe worth adding also some comments
to the `jvmArgs` below:
```
// The following option `--add-opens=java.base/java.nio=ALL-UNNAMED` is
required in jdk17+
// to avoid error. See
https://arrow.apache.org/docs/java/install.html#java-compatibility
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
