caicancai commented on code in PR #3787: URL: https://github.com/apache/calcite/pull/3787#discussion_r1591682198
########## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ########## @@ -7735,23 +7735,16 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias functionAlias) { final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK); f.checkScalar("map_entries(map['foo', 1, 'bar', 2])", "[{foo, 1}, {bar, 2}]", "RecordType(CHAR(3) NOT NULL f0, INTEGER NOT NULL f1) NOT NULL ARRAY NOT NULL"); - f.checkScalar("map_entries(map['foo', 1, null, 2])", "[{foo, 1}, {null, 2}]", - "RecordType(CHAR(3) f0, INTEGER NOT NULL f1) NOT NULL ARRAY NOT NULL"); + Review Comment: @chucheng92 I looked at the git submission record and it was chucheng92 who submitted these tests. Can you help me check this PR when you are free? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org