jduo commented on PR #3757: URL: https://github.com/apache/calcite/pull/3757#issuecomment-2116136876
> LGTM, thanks @jduo for taking care of the comments, can you squash the commits into a single one and make sure the commit message matches exactly the title of the Jira ticket preceded by `[CALCITE-6340]` (you can check the guidelines [here](https://calcite.apache.org/develop/#contributing) if you are in doubt). > > After that, I will wait for a couple more days in case someone has further comments, then I will merge. Thanks @asolimando . I've squashed and updated the title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org