NobiGo commented on code in PR #3798:
URL: https://github.com/apache/calcite/pull/3798#discussion_r1613259892
##########
core/src/main/java/org/apache/calcite/sql/dialect/HiveSqlDialect.java:
##########
@@ -80,6 +82,10 @@ public HiveSqlDialect(Context context) {
@Override public void unparseCall(final SqlWriter writer, final SqlCall call,
final int leftPrec, final int rightPrec) {
switch (call.getKind()) {
+ case ARRAY_VALUE_CONSTRUCTOR:
+ case MAP_VALUE_CONSTRUCTOR:
+ unparseSparkArrayAndMap(writer, call, leftPrec, rightPrec);
Review Comment:
Hi, Thanks for the review. This name means we use SparkSQL standard to
handle Array and Map, Like SparkSqlDialect and StarRocksSqlDialect use
unparseHiveTrim method to handle the Trim. So I think it's Ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
