YiwenWu commented on code in PR #3800:
URL: https://github.com/apache/calcite/pull/3800#discussion_r1617310267
##########
core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java:
##########
@@ -443,7 +443,8 @@ public static boolean mayBeSatisfiable(RexNode e) {
for (RexNode disjunction : disjunctions) {
switch (disjunction.getKind()) {
case LITERAL:
- if (!RexLiteral.booleanValue(disjunction)) {
+ if (!RexLiteral.isNullLiteral(disjunction)
Review Comment:
A problem: Is it reasonable to generate null value?
I'm not sure whether the null value is caused by the error handling of the
following method
```
final RexNode viewPred =
RexUtil.swapTableColumnReferences(rexBuilder, targetPreds.right,
sourceToTargetTableMapping.inverse(),
sourceEC.getEquivalenceClassesMap());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
