fanluoo commented on code in PR #3808:
URL: https://github.com/apache/calcite/pull/3808#discussion_r1625540659
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3072,24 +3072,33 @@ private SqlDialect nonOrdinalDialect() {
sql(query).dialect(HiveSqlDialect.DEFAULT).ok(expected);
}
- @Test void testMysqlCastToBigint() {
Review Comment:
> minor: recommended to add new unit tests and annotate corresponding jira
link.
Thank you for your suggestion. I have added corresponding jira link
comments, but I think this is the same type conversion issue. It would be
better to handle different dialect specificity in one test case, otherwise
there may be many redundant test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
