normanj-bitquill commented on code in PR #3826:
URL: https://github.com/apache/calcite/pull/3826#discussion_r1664547504
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/JavaRowFormat.java:
##########
@@ -256,6 +262,25 @@ public enum JavaRowFormat {
}
return EnumUtils.convert(e, fromType, fieldType);
}
+
+ @Override public Expression fieldDynamic(Expression expression, Expression
field) {
+ return Expressions.arrayIndex(expression, field);
+ }
+
+ @Override public Expression setFieldDynamic(Expression expression,
Expression field,
+ Expression value) {
+ final IndexExpression e =
+ Expressions.arrayIndex(expression, Expressions.constant(field));
+ return Expressions.assign(e, value);
+ }
+
+ @Override public @Nullable Expression copy(ParameterExpression parameter,
+ ParameterExpression outputArray, int outputStartIndex, int length) {
+
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
