YiwenWu commented on code in PR #3830: URL: https://github.com/apache/calcite/pull/3830#discussion_r1666777819
########## site/_docs/reference.md: ########## @@ -2850,6 +2850,7 @@ In the following: | b | REGEXP_SUBSTR(string, regexp [, position [, occurrence]]) | Synonym for REGEXP_EXTRACT | b m p s | REPEAT(string, integer) | Returns a string consisting of *string* repeated of *integer* times; returns an empty string if *integer* is less than 1 | b m | REVERSE(string) | Returns *string* with the order of the characters reversed +| s | REVERSE(string | array) | Returns *string* with the characters in reverse order or array with elements in reverse order Review Comment: I do not think so, you can arbitrarily find a func with a string, and funcName(integer) is supported, and not only for spark, but also for other engines. <img width="273" alt="image" src="https://github.com/apache/calcite/assets/7956306/e45a312f-401c-400b-abef-2e5a7716dab3";> Implicit conversions are supported because `FamilyOperandTypeChecker#checkOperandTypes` is handled: <img width="663" alt="image" src="https://github.com/apache/calcite/assets/7956306/9ffe07d3-ff4b-4e24-8c52-459b3f04530f";> More references: [Design of Calcite Implicit Type Cast](https://docs.google.com/document/d/1g2RUnLXyp_LjUlO-wbblKuP5hqEu3a_2Mt2k4dh6RwU/edit#heading=h.bnu0wb9cokyk) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
