normanj-bitquill commented on code in PR #3801:
URL: https://github.com/apache/calcite/pull/3801#discussion_r1676332438
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -563,12 +563,58 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding
operatorBinding,
OperandTypes.STRING_STRING_OPTIONAL_INTEGER_OPTIONAL_INTEGER_OPTIONAL_INTEGER,
SqlFunctionCategory.STRING);
+ /** The "REGEXP_REPLACE(value, regexp)"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {REDSHIFT})
+ public static final SqlFunction REGEXP_REPLACE_2 =
+ new SqlBasicFunction("REGEXP_REPLACE", SqlKind.OTHER_FUNCTION,
+ SqlSyntax.FUNCTION, true, ReturnTypes.VARCHAR_NULLABLE, null,
+ OperandHandlers.DEFAULT, OperandTypes.STRING_STRING, 0,
+ SqlFunctionCategory.STRING, call -> SqlMonotonicity.NOT_MONOTONIC,
false) { };
+
+ /** The "REGEXP_REPLACE(value, regexp, rep)"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {BIG_QUERY, MYSQL, ORACLE, REDSHIFT})
+ public static final SqlFunction REGEXP_REPLACE_3 =
+ SqlBasicFunction.create("REGEXP_REPLACE", ReturnTypes.VARCHAR_NULLABLE,
+ OperandTypes.STRING_STRING_STRING, SqlFunctionCategory.STRING);
+
/** The "REGEXP_REPLACE(value, regexp, rep [, pos [, occurrence [,
matchType]]])"
* function. Replaces all substrings of value that match regexp with
* {@code rep} and returns modified value. */
@LibraryOperator(libraries = {BIG_QUERY, MYSQL, ORACLE, REDSHIFT})
public static final SqlFunction REGEXP_REPLACE = new
SqlRegexpReplaceFunction();
Review Comment:
Removed. This class was looking at the `SqlConformanceEnum` to decide on how
capture groups are specified in the replacement. BigQuery uses `\\` and others
use `$`. There is now a new LibraryOperator for BigQuery so that `\\` in the
replacement is converted to `$` before doing the replacement.
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -563,12 +563,58 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding
operatorBinding,
OperandTypes.STRING_STRING_OPTIONAL_INTEGER_OPTIONAL_INTEGER_OPTIONAL_INTEGER,
SqlFunctionCategory.STRING);
+ /** The "REGEXP_REPLACE(value, regexp)"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {REDSHIFT})
+ public static final SqlFunction REGEXP_REPLACE_2 =
+ new SqlBasicFunction("REGEXP_REPLACE", SqlKind.OTHER_FUNCTION,
+ SqlSyntax.FUNCTION, true, ReturnTypes.VARCHAR_NULLABLE, null,
+ OperandHandlers.DEFAULT, OperandTypes.STRING_STRING, 0,
+ SqlFunctionCategory.STRING, call -> SqlMonotonicity.NOT_MONOTONIC,
false) { };
+
+ /** The "REGEXP_REPLACE(value, regexp, rep)"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {BIG_QUERY, MYSQL, ORACLE, REDSHIFT})
+ public static final SqlFunction REGEXP_REPLACE_3 =
+ SqlBasicFunction.create("REGEXP_REPLACE", ReturnTypes.VARCHAR_NULLABLE,
+ OperandTypes.STRING_STRING_STRING, SqlFunctionCategory.STRING);
+
/** The "REGEXP_REPLACE(value, regexp, rep [, pos [, occurrence [,
matchType]]])"
* function. Replaces all substrings of value that match regexp with
* {@code rep} and returns modified value. */
@LibraryOperator(libraries = {BIG_QUERY, MYSQL, ORACLE, REDSHIFT})
public static final SqlFunction REGEXP_REPLACE = new
SqlRegexpReplaceFunction();
+ /** The "REGEXP_REPLACE(value, regexp, rep [, flags])"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {POSTGRESQL}, exceptLibraries = REDSHIFT)
+ public static final SqlFunction REGEXP_REPLACE_PG_3 =
+ new SqlBasicFunction("REGEXP_REPLACE", SqlKind.OTHER_FUNCTION,
+ SqlSyntax.FUNCTION, true, ReturnTypes.VARCHAR_NULLABLE, null,
+ OperandHandlers.DEFAULT, OperandTypes.STRING_STRING_STRING, 0,
+ SqlFunctionCategory.STRING, call -> SqlMonotonicity.NOT_MONOTONIC,
false) { };
+
+ /** The "REGEXP_REPLACE(value, regexp, rep, flags)"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {POSTGRESQL}, exceptLibraries = REDSHIFT)
+ public static final SqlFunction REGEXP_REPLACE_PG_4 =
+ new SqlBasicFunction("REGEXP_REPLACE", SqlKind.OTHER_FUNCTION,
+ SqlSyntax.FUNCTION, true, ReturnTypes.VARCHAR_NULLABLE, null,
+ OperandHandlers.DEFAULT, OperandTypes.STRING_STRING_STRING_STRING, 0,
+ SqlFunctionCategory.STRING, call -> SqlMonotonicity.NOT_MONOTONIC,
false) { };
+
+ /** The PostgreSQL variant of
+ * "REGEXP_REPLACE(value, regexp, rep [, pos [, occurrence]] [, matchType])"
+ * function. Replaces all substrings of value that match regexp with
+ * {@code rep} and returns modified value. */
+ @LibraryOperator(libraries = {POSTGRESQL})
+ public static final SqlFunction PG_REGEXP_REPLACE = new
SqlPgRegexpReplaceFunction();
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
