timgrein commented on code in PR #3869:
URL: https://github.com/apache/calcite/pull/3869#discussion_r1687165564
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlTrimFunction.java:
##########
@@ -130,6 +130,9 @@ public SqlTrimFunction(String name, SqlKind kind,
if (operands[1] == null) {
operands[1] = SqlLiteral.createCharString(" ", pos);
}
+ if (operands[2] == null) {
+ throw new IllegalArgumentException("String to trim cannot be null");
Review Comment:
I think it's either the first or the third:
You can specify one argument (only the string to trim) or three (where to
trim (leading, trailing both sides), what to trim from the string, the string
to trim).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
