asolimando commented on PR #3894: URL: https://github.com/apache/calcite/pull/3894#issuecomment-2262308289
@clayburn, thanks a lot for this PR. LGTM but we need to associate this change to a Jira ticket (it's the same for all non-trivial changes). How to write the ticket and your commits is detailed here: https://calcite.apache.org/develop/#contributing The name of the PR seems good as Jira ticket name, and that will have to be the single commit message (prefixed by "[CALCITE-XYZ]"), which will also be in our release notes. The PR description seems a good start for the Jira ticket description, if you happen to have some link supporting the statements they would be welcome, but it's not mandatory. When this is fixed, I will be able to approve and merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
