(calcite) branch main updated: [CALCITE-6514] Enable tests about AssertionError while translating IN list that contains null

[mbudiu]

This is an automated email from the ASF dual-hosted git repository.

mbudiu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git


The following commit(s) were added to refs/heads/main by this push:
     new 979981481f [CALCITE-6514] Enable tests about AssertionError while 
translating IN list that contains null
979981481f is described below

commit 979981481f8effde5e2fe5bb605d5c3424554e4b
Author: Xiong Duan <nobigo...@gmail.com>
AuthorDate: Sat Aug 3 10:11:38 2024 +0800

    [CALCITE-6514] Enable tests about AssertionError while translating IN list 
that contains null
---
 core/src/main/java/org/apache/calcite/util/Bug.java          |  7 -------
 .../main/java/org/apache/calcite/test/SqlOperatorTest.java   | 12 ++++--------
 2 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/core/src/main/java/org/apache/calcite/util/Bug.java 
b/core/src/main/java/org/apache/calcite/util/Bug.java
index 989df00fdc..a6594f6e82 100644
--- a/core/src/main/java/org/apache/calcite/util/Bug.java
+++ b/core/src/main/java/org/apache/calcite/util/Bug.java
@@ -56,13 +56,6 @@ public abstract class Bug {
 
   public static final boolean DT785_FIXED = false;
 
-  /**
-   * Whether <a href="http://issues.eigenbase.org/browse/FRG-327";>issue
-   * FRG-327: AssertionError while translating IN list that contains null</a>
-   * is fixed.
-   */
-  public static final boolean FRG327_FIXED = false;
-
   /**
    * Whether <a href="http://issues.eigenbase.org/browse/FRG-377";>issue
    * FRG-377: Regular character set identifiers defined in SQL:2008 spec like
diff --git a/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java 
b/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
index d3679c0ab1..18f4a4e9fb 100644
--- a/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
+++ b/testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
@@ -2852,10 +2852,8 @@ public class SqlOperatorTest {
     f.checkBoolean("cast(null as integer) in (0, 1, 2)", null);
     f.checkBoolean("cast(null as integer) in (0, cast(null as integer), 2)",
         null);
-    if (Bug.FRG327_FIXED) {
-      f.checkBoolean("cast(null as integer) in (0, null, 2)", null);
-      f.checkBoolean("1 in (0, null, 2)", null);
-    }
+    f.checkBoolean("cast(null as integer) in (0, null, 2)", null);
+    f.checkBoolean("1 in (0, null, 2)", null);
 
     if (!f.brokenTestsEnabled()) {
       return;
@@ -2880,10 +2878,8 @@ public class SqlOperatorTest {
     f.checkBoolean("cast(null as integer) not in (0, 1, 2)", null);
     f.checkBoolean("cast(null as integer) not in (0, cast(null as integer), 
2)",
         null);
-    if (Bug.FRG327_FIXED) {
-      f.checkBoolean("cast(null as integer) not in (0, null, 2)", null);
-      f.checkBoolean("1 not in (0, null, 2)", null);
-    }
+    f.checkBoolean("cast(null as integer) not in (0, null, 2)", null);
+    f.checkBoolean("1 not in (0, null, 2)", null);
 
     // AND has lower precedence than NOT IN
     f.checkBoolean("true and false not in (true, true)", true);