caicancai commented on code in PR #3905:
URL: https://github.com/apache/calcite/pull/3905#discussion_r1710542190
##########
core/src/main/java/org/apache/calcite/sql/SqlFunction.java:
##########
@@ -310,7 +310,9 @@ argTypes, argNames, getFunctionType(), SqlSyntax.FUNCTION,
// if we succeed, the arguments would be wrapped with CAST operator.
if (function != null) {
TypeCoercion typeCoercion = validator.getTypeCoercion();
- if (typeCoercion.userDefinedFunctionCoercion(scope, call,
function)) {
+ if ((function.category == SqlFunctionCategory.USER_DEFINED_FUNCTION
Review Comment:
I'm not really sure why these judgments are made. Maybe I can guess a
little, but it may not be very accurate. Should JavaDoc be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
