NobiGo commented on code in PR #3917: URL: https://github.com/apache/calcite/pull/3917#discussion_r1722467868
########## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Primitive.java: ########## @@ -385,22 +385,20 @@ static void checkRoundedRange(Number value, double min, double max) { } /** Called from BuiltInMethod.INTEGER_CAST */ - public static @Nullable Object integerCast(Primitive primitive, final Object value) { - return requireNonNull(primitive, "primitive").numberValue((Number) value); + public static @Nullable Object integerCast(Primitive primitive, final Object value, Review Comment: Ok. I will add a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org