NobiGo commented on code in PR #3917: URL: https://github.com/apache/calcite/pull/3917#discussion_r1722978904
########## core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystem.java: ########## @@ -35,6 +37,13 @@ public interface RelDataTypeSystem { /** Default type system. */ RelDataTypeSystem DEFAULT = new RelDataTypeSystemImpl() { }; + /** Same as {@link #DEFAULT}. But the rounding mode is {@link RoundingMode#HALF_UP}. */ + RelDataTypeSystem DEFAULT_ROUNDING_MODE_HALF_UP = new RelDataTypeSystemImpl() { Review Comment: This may be a suitable place because I want to test this PR through Quidem. To avoid any misunderstandings, I have added the relevant Java document 'Only for testing'` to make it clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org