NobiGo commented on code in PR #3945:
URL: https://github.com/apache/calcite/pull/3945#discussion_r1745651932
##########
core/src/main/java/org/apache/calcite/rel/type/DelegatingTypeSystem.java:
##########
@@ -52,6 +52,14 @@ protected DelegatingTypeSystem(RelDataTypeSystem typeSystem)
{
return typeSystem.getMaxNumericPrecision();
}
+ @Override public boolean supportsNegativeScale() {
+ boolean isSupportNegativeScale = typeSystem.supportsNegativeScale();
+ if (isSupportNegativeScale) {
Review Comment:
Because this PR only solves the issue when supportsNegativeScale is false.
Will support negative scale in CALCITE-6406.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
