dssysolyatin commented on code in PR #3896:
URL: https://github.com/apache/calcite/pull/3896#discussion_r1795661904
##########
mongodb/src/main/java/org/apache/calcite/adapter/mongodb/MongoRules.java:
##########
@@ -114,10 +114,14 @@ static String quote(String s) {
}
private static boolean needsQuote(String s) {
- for (int i = 0, n = s.length(); i < n; i++) {
+ if (!s.isEmpty()
Review Comment:
@NobiGo, could you please recheck the PR? Instead of fixing individual
quoting cases, I decided to quote every identifier because MongoDB Extended
JSON conforms to the JSON RFC. Therefore, it is safe to use double quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
