zhuqi-lucas commented on code in PR #4027:
URL: https://github.com/apache/calcite/pull/4027#discussion_r1826543602


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -914,6 +914,29 @@ public static List<String> split(String s, String 
delimiter) {
     }
   }
 
+
+  /** SQL {@code SPLIT_PART(string, string, int)} function. */
+  public static String splitPart(String s, String delimiter, int n) {
+    if (Strings.isNullOrEmpty(s) || delimiter == null || delimiter.isEmpty() 
|| n == 0) {

Review Comment:
   Good catch, addressed in latest PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to