mihaibudiu commented on code in PR #4031:
URL: https://github.com/apache/calcite/pull/4031#discussion_r1827159849
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTranslator.java:
##########
@@ -170,11 +170,49 @@ private String translateBinary(String op, String rop,
RexCall call) {
case CAST:
// FIXME This will not work in all cases (for example, we ignore string
encoding)
return translateBinary2(op, ((RexCall) left).operands.get(0), right);
+ case PLUS:
+ right = translateArithmeticOp(left, right);
+ return translateBinary2(op, ((RexCall) left).operands.get(0), right);
+ case MINUS:
Review Comment:
these two cases could be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
