mihaibudiu commented on code in PR #4024:
URL: https://github.com/apache/calcite/pull/4024#discussion_r1828380316
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7777,7 +7777,7 @@ private void checkLiteral2(String expression, String
expected) {
final String expectedDefault = "INSERT INTO \"SCOTT\".\"DEPT\""
+ " (\"DEPTNO\", \"DNAME\", \"LOC\")\n"
+ "VALUES (1, 'Fred', 'San Francisco'),\n"
- + "(2, 'Eric', 'Washington ')";
Review Comment:
The types of these fields in the Scott database is actually VARCHAR(20), and
VARCHAR types are not supposed to store the padding spaces, unlike CHAR(N)
types. So the result is correct. I don't know exactly why the result was wrong
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
