mihaibudiu commented on code in PR #4032:
URL: https://github.com/apache/calcite/pull/4032#discussion_r1833496780
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTranslator.java:
##########
@@ -133,6 +133,15 @@ private String translateMatch2(RexNode node) {
return translateUnary("isnull", (RexCall) node);
case IS_NOT_NULL:
return translateUnary("isnotnull", (RexCall) node);
+ case IS_NOT_TRUE:
+ return translateUnary("isnottrue", (RexCall) node);
+ case IS_NOT_FALSE:
+ return translateUnary("isnotfalse", (RexCall) node);
+ case INPUT_REF:
Review Comment:
The JavaDoc on this function is actually wrong, which leads to the confusion.
The JavaDoc should say that node is always an expression that evaluates to a
Boolean value. This is only called from translateAnd. With this information the
implementation makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
