zabetak commented on PR #4013: URL: https://github.com/apache/calcite/pull/4013#issuecomment-2491027237
The codebase has already "minimization" code in various other places (e.g., `RelMdUniqueKeys#filterSupersets`) and there is overlapping functionality with the new `ImmutableBitSet#isMinimal` API. Based on these findings, I don't think a new API is necessary thus I [reverted](https://github.com/apache/calcite/pull/4013/commits/1e3b09a02bf465320b327de9714ec30c12e29e65) the respective code changes from. If we want to add a new public API its better to refactor/use the existing "minimization" logic. However, the refactoring will require some discussion on where to move the code and how we want the API to look like so it is out of the scope of this PR. If there are no objections I plan to merge this PR as is in ~24hrs. If people feel that we need more work on the minimization checks/logic let me know and we can discuss this under a dedicated JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
