kgyrtkirk commented on code in PR #4077:
URL: https://github.com/apache/calcite/pull/4077#discussion_r1871025204
##########
core/src/test/java/org/apache/calcite/sql2rel/RelFieldTrimmerTest.java:
##########
@@ -544,4 +548,36 @@ public static Frameworks.ConfigBuilder config() {
+ " LogicalTableScan(table=[[scott, EMP]])\n";
assertThat(trimmed, hasTree(expected));
}
+
+ @Test void testLogicalCorrelateFieldTrimmer() {
+ final RelBuilder builder = RelBuilder.create(config().build());
+ final Holder<@Nullable RexCorrelVariable> v = Holder.empty();
+ RelNode root = builder.scan("EMP")
+ .projectPlus(builder.call(SqlStdOperatorTable.PLUS, builder.field(0),
builder.field(0)))
+ .variable(v::set)
+ .scan("DEPT")
+ .filter(
+ builder.equals(builder.field(0),
+ builder.call(
+ SqlStdOperatorTable.PLUS,
+ builder.literal(10),
+ builder.field(v.get(), "DEPTNO"))))
+ .correlate(JoinRelType.LEFT, v.get().id, builder.field(2, 0, "DEPTNO"))
+ .aggregate(builder.groupKey("ENAME"),
builder.max(builder.field("EMPNO")))
+ .build();
+
+ final RelFieldTrimmer fieldTrimmer = new RelFieldTrimmer(null, builder);
+ final RelNode trimmed = fieldTrimmer.trim(root);
+ final String expected = ""
Review Comment:
I've updated the testcase to use an `Uncollect` instead - and also added the
before-trim plan to the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
