AstraHoo commented on code in PR #4114:
URL: https://github.com/apache/calcite/pull/4114#discussion_r1898362611
##########
spark/build.gradle.kts:
##########
@@ -31,5 +31,5 @@ dependencies {
runtimeOnly("xerces:xercesImpl")
testImplementation(project(":testkit"))
- testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl")
+ testRuntimeOnly("org.slf4j:slf4j-reload4j")
Review Comment:
Before:
SparkAdapterTest > testFilterTrue() STANDARD_ERROR
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/Users/hubinhua/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-slf4j-impl/2.17.1/84692d456bcce689355d33d68167875e486954dd/log4j-slf4j-impl-2.17.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/Users/hubinhua/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-reload4j/1.7.36/db708f7d959dee1857ac524636e85ecf2e1781c1/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
SLF4J: Actual binding is of type
[org.apache.logging.slf4j.Log4jLoggerFactory]
After:
SparkAdapterTest > testOrderByLimit() STANDARD_OUT
2024-12-27 08:31:25,429 [ForkJoinPool-1-worker-4] INFO - Your platform
does not provide complete low-level API for accessing direct buffers reliably.
Unless explicitly requested, heap buffer will always be preferred to avoid
potential system unstability.
2.7sec, org.apache.calcite.test.SparkAdapterTest >
testFilterFalse()
2.7sec, org.apache.calcite.test.SparkAdapterTest > testFilterTrue()
2.7sec, org.apache.calcite.test.SparkAdapterTest >
testOrderByLimit()
2.8sec, org.apache.calcite.test.SparkAdapterTest >
testSortXDescYDescProjectY()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
