a-rafay commented on code in PR #4113:
URL: https://github.com/apache/calcite/pull/4113#discussion_r1898659822
##########
core/src/main/java/org/apache/calcite/rel/rules/ProjectWindowTransposeRule.java:
##########
@@ -217,6 +217,15 @@ private static ImmutableBitSet findReference(final Project
project,
}
}
+ List<RexNode> analyze = new ArrayList<>();
+ if (group.lowerBound.getOffset() != null) {
+ analyze.add(group.lowerBound.getOffset());
+ }
+ if (group.upperBound.getOffset() != null) {
+ analyze.add(group.upperBound.getOffset());
+ }
+ referenceFinder.apply(analyze);
+
Review Comment:
Why not simply:
```
group.lowerBound.accept(referenceFinder);
group.upperBound.accept(referenceFinder);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
