ILuffZhe commented on code in PR #4116:
URL: https://github.com/apache/calcite/pull/4116#discussion_r1898784908
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -4271,6 +4271,10 @@ public static int toInt(java.sql.Time v) {
return v == null ? castNonNull(null) : toInt(v);
}
+ // Method tagged as non-deterministic because it can throw.
+ // The DeterministicCodeOptimizer may otherwise try to lift it out of
try-catch blocks.
Review Comment:
Nit: the indent.
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -4271,6 +4271,10 @@ public static int toInt(java.sql.Time v) {
return v == null ? castNonNull(null) : toInt(v);
}
+ // Method tagged as non-deterministic because it can throw.
+ // The DeterministicCodeOptimizer may otherwise try to lift it out of
try-catch blocks.
+ // See https://issues.apache.org/jira/browse/CALCITE-6753
Review Comment:
Is this change should be added in CALCITE-6753?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
