NobiGo commented on code in PR #4112:
URL: https://github.com/apache/calcite/pull/4112#discussion_r1900169562
##########
core/src/main/java/org/apache/calcite/jdbc/Driver.java:
##########
@@ -101,13 +101,12 @@ public CalcitePrepare createPrepare() {
if (prepareFactory != null) {
return prepareFactory.get();
}
- return createPrepareFactory().apply();
+ return CalcitePrepare.DEFAULT_FACTORY.apply();
}
/** Returns a factory with which to create a {@link CalcitePrepare}.
*
- * <p>Now deprecated; if you wish to use a custom prepare, overrides of this
- * method will still work, but we prefer that you call
+ * <p>Now deprecated; if you wish to use a custom prepare, please call
Review Comment:
Can't we override this method now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
