xiaochen-zhou commented on code in PR #4124:
URL: https://github.com/apache/calcite/pull/4124#discussion_r1906200537
##########
core/src/main/java/org/apache/calcite/sql/dialect/PrestoSqlDialect.java:
##########
@@ -86,7 +88,11 @@ public PrestoSqlDialect(Context context) {
}
@Override public boolean supportsImplicitTypeCoercion(RexCall call) {
- return false;
+ return super.supportsImplicitTypeCoercion(call)
+ && RexUtil.isLiteral(call.getOperands().get(0), false)
Review Comment:
> this seems to do more than the JIRA issue states: it will not convert a
literal except to numeric, date, or timestamp types. But you are not
considering the literal type.
I have updated the code. Please take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
