mihaibudiu commented on code in PR #4130:
URL: https://github.com/apache/calcite/pull/4130#discussion_r1908050875
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -127,15 +127,15 @@ class JdbcAdapterTest {
+ " JdbcFilter(condition=[<($0, 10)])\n"
+ " JdbcTableScan(table=[[foodmart, store]])\n"
+ " JdbcToEnumerableConverter\n"
- + " JdbcProject(EXPR$0=[CAST($1):VARCHAR(30)])\n"
+ + " JdbcProject(ENAME=[CAST($1):VARCHAR(30)])\n"
+ " JdbcFilter(condition=[>(CAST($0):INTEGER NOT NULL,
10)])\n"
+ " JdbcTableScan(table=[[SCOTT, EMP]])")
.runs()
.enable(CalciteAssert.DB == CalciteAssert.DatabaseInstance.HSQLDB)
.planHasSql("SELECT \"store_name\"\n"
+ "FROM \"foodmart\".\"store\"\n"
+ "WHERE \"store_id\" < 10")
- .planHasSql("SELECT CAST(\"ENAME\" AS VARCHAR(30))\n"
+ .planHasSql("SELECT CAST(\"ENAME\" AS VARCHAR(30)) AS \"ENAME\"\n"
Review Comment:
This preserves the names from the original select list that is being
transformed.
If the original list had duplicates, this one should too.
But I expect that this cannot happen at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
