mihaibudiu commented on code in PR #4158:
URL: https://github.com/apache/calcite/pull/4158#discussion_r1925746752
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -4431,6 +4431,14 @@ private void validateModality(SqlNode query) {
default:
break;
}
+ } else if (query.getKind() == SqlKind.WITH) {
+ // The modality of With clause depends on its body
+ // For example:
+ // SQL: WITH STREMTABLE AS SELECT STREAM * FROM KAFKA.MOCKTABLE SELET *
FROM STREMTABLE
Review Comment:
is this supposed to be STREAMTABLE?
SELECT is also mistyped
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -4431,6 +4431,14 @@ private void validateModality(SqlNode query) {
default:
break;
}
+ } else if (query.getKind() == SqlKind.WITH) {
+ // The modality of With clause depends on its body
Review Comment:
I think this should be indented deeper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
