mihaibudiu commented on code in PR #4189:
URL: https://github.com/apache/calcite/pull/4189#discussion_r1949704657
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3020,10 +3020,30 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM \"foodmart\".\"product\"\n"
+ "LIMIT 100\n"
+ "OFFSET 10";
+ final String expectedPostgresql = "SELECT \"product_id\"\n"
+ + "FROM \"foodmart\".\"product\"\n"
+ + "LIMIT 100\n"
+ + "OFFSET 10";
+ final String expectedPhoenix = "SELECT \"product_id\"\n"
+ + "FROM \"foodmart\".\"product\"\n"
+ + "LIMIT 100\n"
+ + "OFFSET 10";
+ final String expectedParaccle = "SELECT \"product_id\"\n"
+ + "FROM \"foodmart\".\"product\"\n"
+ + "LIMIT 100\n"
+ + "OFFSET 10";
+ final String expectedTeradata = "SELECT \"product_id\"\n"
Review Comment:
if these strings are equal, why not reuse them? This makes it easier to
review and maintain.
`String expectedTeradata = expectedPostgresql`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
