NobiGo commented on code in PR #4206:
URL: https://github.com/apache/calcite/pull/4206#discussion_r1963391199
##########
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##########
@@ -338,8 +338,9 @@ public static SqlCall stripSeparator(SqlCall call) {
/**
* Type-inference strategy that returns the type of the first operand,
* unless it is a DATE, in which case the return type is TIMESTAMP. Supports
- * cases such as <a
href="https://issues.apache.org/jira/browse/CALCITE-5757";>[CALCITE-5757]
- * Incorrect return type for BigQuery TRUNC functions </a>.
+ * cases such as
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5757";>[CALCITE-5757]
+ * Incorrect return type for BigQuery TRUNC functions</a>.
Review Comment:
`</a>. */`
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -2882,10 +2882,9 @@ private CorelMap(Multimap<RelNode, CorRef>
mapRefRelToCorRef,
}
@Override public String toString() {
- return "mapRefRelToCorRef=" + mapRefRelToCorRef
- + "\nmapCorToCorRel=" + mapCorToCorRel
- + "\nmapFieldAccessToCorRef=" + mapFieldAccessToCorRef
- + "\n";
+ return "mapRefRelToCorRef=" + mapRefRelToCorRef + "\n"
Review Comment:
Must the newline in a string literal be performed according to some
standard, or is there a grade plugin that can reformat it? And I noticed that
method calls must not end with a `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
