NobiGo commented on code in PR #4209:
URL: https://github.com/apache/calcite/pull/4209#discussion_r1967528892
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -9585,4 +9585,12 @@ private void
checkJoinAssociateRuleWithTopAlwaysTrueCondition(boolean allowAlway
.withRule(CoreRules.MULTI_JOIN_OPTIMIZE)
.check();
}
+
+ @Test void testIntersectToExistsRule() {
Review Comment:
1. Please add the Jira link
2. Add more test cases about
- INTERSECT ALL
- INTERSECT on multiple fields
- Multiple INTERSECT
3. We may not adopt this rule as the default one for now, but it can be set
as the default rule to test whether the rule function is normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
