rubenada commented on PR #4207:
URL: https://github.com/apache/calcite/pull/4207#issuecomment-2682611028

   @xiedeyantu please amend the commit message, it shall not begin with 
"Fix..." but rather describe the issue
   ```
   Expected: an empty collection
            but: <[invalid git log message '[CALCITE-6850] Fix 
ProjectRemoveRule stripped can not get Project type never'; contains 'fix' or 
'fixes'; you should describe the problem, not what you did]>
   ```
   I would suggest something along the lines "ProjectRemoveRule with two 
Projects does not keep field names from the top one"; and use it everywhere 
(Jira title, PR title, commit message) to keep consistency
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to