xuzifu666 commented on PR #4218: URL: https://github.com/apache/calcite/pull/4218#issuecomment-2688112551
> At the moment I am not sure there is a problem as `IS_NULL`/`IS_NOT_NULL` is handled exactly the same way (look at `toIsNullKindDruidFilter`), either we have a problem in both or they are correct as-is. > > Can you please verify with a test actually running against Druid for both cases? @asolimando Very thanks for your attention on this pr，I thought again here just a logic error before，due to code here would only be DRUID_IN or DRUID_NOT_IN, so here should judge for SqlKind.DRUID_IN not SqlKind.IN. I had change the logic in PR and add a test for NOT IN case. PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
