silundong commented on PR #4204: URL: https://github.com/apache/calcite/pull/4204#issuecomment-2699479377
> @silundong I have left some remarks , rather generic or Calcite-related, not really dphyp-algo related, which I find I bit hard to follow, but it's good that you provided tests showing the results. IMO we could consider adding this feature, maybe initially flagging the new classes and rule definitions as `@Experimental` (as it happened in the past with other features). Let's see what other contributors think about it... Thank you very much for your suggestion, I will update them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
