suibianwanwank commented on code in PR #4209: URL: https://github.com/apache/calcite/pull/4209#discussion_r1981311531
########## core/src/main/java/org/apache/calcite/rel/rules/IntersectToExistsRule.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.rules; + +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelOptUtil.Exists; +import org.apache.calcite.plan.RelRule; +import org.apache.calcite.plan.hep.HepRelVertex; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.CorrelationId; +import org.apache.calcite.rel.core.Intersect; +import org.apache.calcite.rel.logical.LogicalIntersect; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeField; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.rex.RexSubQuery; +import org.apache.calcite.rex.RexUtil; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.tools.RelBuilder; +import org.apache.calcite.tools.RelBuilderFactory; +import org.apache.calcite.util.ImmutableBitSet; + +import com.google.common.collect.ImmutableSet; + +import org.immutables.value.Value; + +import java.util.ArrayList; +import java.util.List; +import java.util.stream.Collectors; + +/** + * Planner rule that translates a {@link Intersect} + * (<code>all</code> = <code>false</code>) + * into a {@link Exists}. + * + * @see CoreRules#INTERSECT_TO_EXISTS + */ [email protected] +public class IntersectToExistsRule + extends RelRule<IntersectToExistsRule.Config> + implements TransformationRule { + + /** Creates an IntersectToExistRule. */ + protected IntersectToExistsRule(Config config) { + super(config); + } + + @Deprecated // to be removed before 2.0 + public IntersectToExistsRule(Class<? extends Intersect> intersectClass, + RelBuilderFactory relBuilderFactory) { + this(Config.DEFAULT.withRelBuilderFactory(relBuilderFactory) + .as(Config.class) + .withOperandFor(intersectClass)); + } + + //~ Methods ---------------------------------------------------------------- + + @Override public void onMatch(RelOptRuleCall call) { + final Intersect intersect = call.rel(0); + if (intersect.all) { + return; // nothing we can do + } + + final RelBuilder builder = call.builder(); + final RexBuilder rexBuilder = builder.getRexBuilder(); + + RelDataType rowType = intersect.getRowType(); + List<RelNode> inputs = intersect.getInputs(); + RelNode current = inputs.get(0); + + // get all column indices of intersect + ImmutableBitSet fieldIndices = ImmutableBitSet.of(rowType.getFieldList() + .stream().map(RelDataTypeField::getIndex) + .collect(Collectors.toList())); + + // iterate over the inputs and apply exists subquery + for (int i = 1; i < inputs.size(); i++) { + RelNode nextInput = removeHepRelVertex(inputs.get(i)); + + // create correlation + CorrelationId correlationId = intersect.getCluster().createCorrel(); + RexNode correl = + rexBuilder.makeCorrel(rowType, correlationId); + + // create condition in exists filter, and use correlation + List<RexNode> conditions = new ArrayList<>(); + for (int fieldIndex : fieldIndices) { + RexNode outerField = rexBuilder.makeInputRef(rowType, fieldIndex); + RexNode innerField = rexBuilder.makeFieldAccess(correl, fieldIndex); + conditions.add( + rexBuilder.makeCall(SqlStdOperatorTable.IS_NOT_DISTINCT_FROM, + outerField, innerField)); + } + RexNode condition = RexUtil.composeConjunction(rexBuilder, conditions); + + // build exists subquery + RelNode existsSubQuery = builder.push(nextInput) + .filter(condition) + .project(builder.fields(fieldIndices)) + .build(); + + // apply exists subquery to the current relation + current = builder.push(current) + .filter(ImmutableSet.of(correlationId), + RexSubQuery.exists(existsSubQuery)) + .build(); + } + + builder.push(current); + List<RexNode> projects = new ArrayList<>(); + for (int fieldIndex : fieldIndices) { + RexNode rexNode = builder.fields().get(fieldIndex); + RelDataType originalType = + rowType.getFieldList().get(projects.size()).getType(); + RexNode expr; + if (!originalType.equals(rexNode.getType())) { Review Comment: What situation is the type adjustment for here? ########## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ########## @@ -244,6 +245,33 @@ private static String toSql(RelNode root, SqlDialect dialect, sql(query).withMysql().ok(expected); } + /** + * Test case of + * <a href="https://issues.apache.org/jira/browse/CALCITE-6836";>[CALCITE-6836] + * Add Rule to convert INTERSECT to EXISTS</a>. */ + @Test void testIntersectToExistsRule() { + String query = "SELECT \"product_name\"\n" Review Comment: In fact, I don't think it's necessary to test in RelToSqlConverter because the semantics of relational algebra is already expressed in RelNode. What is tested here is the correctness of RelNode -> sqlnode -> sqlText. ########## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ########## @@ -9716,4 +9716,50 @@ private void checkJoinAssociateRuleWithTopAlwaysTrueCondition(boolean allowAlway fixture().withRelBuilderConfig(a -> a.withBloat(-1)) .relFn(relFn).withPlanner(planner).check(); } + + /** + * Test case of + * <a href="https://issues.apache.org/jira/browse/CALCITE-6836";>[CALCITE-6836] + * Add Rule to convert INTERSECT to EXISTS</a>. */ + @Test void testIntersectToExistsRuleOneField() { + String sql = "SELECT a.ename FROM emp AS a\n" + + "INTERSECT\n" + + "SELECT b.name FROM dept AS b"; + sql(sql).withRule(CoreRules.INTERSECT_TO_EXISTS) + .check(); + } + + @Test void testIntersectToExistsRulePrimaryKey() { + String sql = "SELECT a.empno FROM emp AS a\n" + + "INTERSECT\n" + + "SELECT b.empno FROM emp AS b"; + sql(sql).withRule(CoreRules.INTERSECT_TO_EXISTS) + .check(); + } + Review Comment: For all remaining tests, also add the jira case ########## core/src/main/java/org/apache/calcite/rel/rules/IntersectToExistsRule.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.rules; + +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelOptUtil.Exists; +import org.apache.calcite.plan.RelRule; +import org.apache.calcite.plan.hep.HepRelVertex; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.CorrelationId; +import org.apache.calcite.rel.core.Intersect; +import org.apache.calcite.rel.logical.LogicalIntersect; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeField; +import org.apache.calcite.rex.RexBuilder; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.rex.RexSubQuery; +import org.apache.calcite.rex.RexUtil; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.tools.RelBuilder; +import org.apache.calcite.tools.RelBuilderFactory; +import org.apache.calcite.util.ImmutableBitSet; + +import com.google.common.collect.ImmutableSet; + +import org.immutables.value.Value; + +import java.util.ArrayList; +import java.util.List; +import java.util.stream.Collectors; + +/** + * Planner rule that translates a {@link Intersect} + * (<code>all</code> = <code>false</code>) + * into a {@link Exists}. + * + * @see CoreRules#INTERSECT_TO_EXISTS + */ [email protected] +public class IntersectToExistsRule + extends RelRule<IntersectToExistsRule.Config> + implements TransformationRule { + + /** Creates an IntersectToExistRule. */ + protected IntersectToExistsRule(Config config) { + super(config); + } + + @Deprecated // to be removed before 2.0 + public IntersectToExistsRule(Class<? extends Intersect> intersectClass, + RelBuilderFactory relBuilderFactory) { + this(Config.DEFAULT.withRelBuilderFactory(relBuilderFactory) + .as(Config.class) + .withOperandFor(intersectClass)); + } + + //~ Methods ---------------------------------------------------------------- + + @Override public void onMatch(RelOptRuleCall call) { + final Intersect intersect = call.rel(0); + if (intersect.all) { + return; // nothing we can do + } + + final RelBuilder builder = call.builder(); + final RexBuilder rexBuilder = builder.getRexBuilder(); + + RelDataType rowType = intersect.getRowType(); + List<RelNode> inputs = intersect.getInputs(); + RelNode current = inputs.get(0); + + // get all column indices of intersect + ImmutableBitSet fieldIndices = ImmutableBitSet.of(rowType.getFieldList() + .stream().map(RelDataTypeField::getIndex) + .collect(Collectors.toList())); + + // iterate over the inputs and apply exists subquery + for (int i = 1; i < inputs.size(); i++) { + RelNode nextInput = removeHepRelVertex(inputs.get(i)); + + // create correlation + CorrelationId correlationId = intersect.getCluster().createCorrel(); + RexNode correl = + rexBuilder.makeCorrel(rowType, correlationId); + + // create condition in exists filter, and use correlation + List<RexNode> conditions = new ArrayList<>(); + for (int fieldIndex : fieldIndices) { + RexNode outerField = rexBuilder.makeInputRef(rowType, fieldIndex); + RexNode innerField = rexBuilder.makeFieldAccess(correl, fieldIndex); + conditions.add( + rexBuilder.makeCall(SqlStdOperatorTable.IS_NOT_DISTINCT_FROM, + outerField, innerField)); + } + RexNode condition = RexUtil.composeConjunction(rexBuilder, conditions); + + // build exists subquery + RelNode existsSubQuery = builder.push(nextInput) + .filter(condition) + .project(builder.fields(fieldIndices)) + .build(); + + // apply exists subquery to the current relation + current = builder.push(current) + .filter(ImmutableSet.of(correlationId), + RexSubQuery.exists(existsSubQuery)) + .build(); + } + + builder.push(current); + List<RexNode> projects = new ArrayList<>(); + for (int fieldIndex : fieldIndices) { + RexNode rexNode = builder.fields().get(fieldIndex); + RelDataType originalType = + rowType.getFieldList().get(projects.size()).getType(); + RexNode expr; + if (!originalType.equals(rexNode.getType())) { + expr = rexBuilder.makeCast(originalType, rexNode, true, false); + } else { + expr = rexNode; + } + projects.add(expr); + } + + RelNode result = builder.project(projects) + .distinct() + .build(); + + call.transformTo(result); + } + + /** + * Will not eliminate HepRelVertex in subqueries + * during the optimization process. + * We need to eliminate it here. */ + private RelNode removeHepRelVertex(RelNode input) { Review Comment: You can learn about stripped(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
